Fix integer overflow in @Order of RepositoryRelProvider
#2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rojects#2477) Signed-off-by: Andrey Litvitski <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
mp911de
added
type: bug
mp911de
pushed a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: Andrey Litvitski <[email protected]> Closes: #2477 Original pull request: #2478
mp911de
pushed a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: Andrey Litvitski <[email protected]> Closes: #2477 Original pull request: #2478
mp911de
pushed a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: Andrey Litvitski <[email protected]> Closes: #2477 Original pull request: #2478
|
Thank you for your contribution. That's merged, polished, and backported now. |
mp911de
pushed a commit
that referenced
this pull request
May 13, 2025
Signed-off-by: Andrey Litvitski <[email protected]> Closes: #2477 Original pull request: #2478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @bgiddens wrote in #2477, it was probably assumed that we didn't want the lowest priority, that's why we subtract 10. However, if we plus, then a stack overflow is triggered and vice versa, the order is highest.
Fixes: #2477